This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): Handle sign of -undefined consistently
#14451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When csp is disabled, evaluating `-undefined` is `-0` and when csp is enabled the evaluation is `0`. In most cases this is not an issue as `0 === -0`, but there is an edge case as `1/0 === Infinity` and `1/-0 === -Infinity`
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
When csp is enabled
$parse('-undefined')is0What is the new behavior (if this is a feature change)?
When csp is enabled
$parse('-undefined')is-0Does this PR introduce a breaking change?
No, this is the way it should work, and the way it works when csp is disabled.
Please check if the PR fulfills these requirements
Other information:
When csp is disabled, evaluating
-undefinedis-0and when csp is enabledthe evaluation is
0. In most cases this is not an issue as0 === -0, butthere is an edge case as
1/0 === Infinityand1/-0 === -Infinity